search

source-separation / tutorial

Tutorial covering Open Source tools for Source Separation.
https://source-separation.github.io/tutorial
Other
351 stars 38 forks source link

Issue on page /training/putting_it_all_together.html #46

Open emilykuowen opened 1 year ago

emilykuowen commented 1 year ago

In the code block for the MaskInference class, connections.append([key, f'model:{key}']) is missing brackets around f'model:{key}, which causes the code to run into a KeyError. The correct code should be connections.append([key, [f'model:{key}']]), as shown in the printed model config of MaskInference later in the HTML.

Farzad-RK commented 1 year ago

@emilykuowen Thank you my friend. I can confirm that I had the same problem. This issue hasn't been been fixed yet.

ethman commented 1 year ago

Would someone mind making a PR?