search

sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
616 stars 88 forks source link

$.UIDeletable binds to the body, unsuitable for multiple deletable lists or dynamic content #16

Closed grrowl closed 10 years ago

grrowl commented 10 years ago

This means every second $.UIDeletable you set up, it will double-bind to the event, making your list unusable (it will toggle the .selected class twice, on then off). Third list is fine. Fourth, unusable.

The problematic bindings are in chui-3.0.6.js, line 345. Also, these events use 'singletap`, not the framework's $.eventStart. Any reason for this?

grrowl commented 10 years ago

I will fix this and submit a pull request shortly.

sourcebits-robertbiggs commented 10 years ago

Hey Tom, why do you want to change the events from singletap to $.eventStart? This will mean that if the user tries to scroll one of the deletable lists and touches a delete indicator or button, it will immediately trigger the action instead of allowing the user to scroll. The singletap is the shortest possible delay that allows the user to scroll on a tappable target.

On Dec 1, 2013, at 7:59 PM, Tom McKenzie notifications@github.com wrote:

I will fix this and submit a pull request shortly.

— Reply to this email directly or view it on GitHub.

sourcebits-robertbiggs commented 10 years ago

This has been resolved in commit: e743b02cd1