search

sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
616 stars 88 forks source link

$.UIDeletable should bind per-deletable-list, use $.eventStart #17

Closed grrowl closed 10 years ago

grrowl commented 10 years ago

Here's a PR for the bug raised in issue #16.

grrowl commented 10 years ago

Ahhh my misunderstanding, I was under the impression that $.eventStart was rate-limited for that, but it I was thinking of singletap (but separated the commits just in case). Feel free to grab the other commit or reimplement as you see fit.

sourcebits-robertbiggs commented 10 years ago

The list fix you did is fine. why don’t you submit a new pull request with that, minus the event change. I’d like you to get credit for what you submit. I’ll cancel the other pull requests.

On Dec 1, 2013, at 8:22 PM, Tom McKenzie notifications@github.com wrote:

Ahhh my misunderstanding, I was under the impression that $.eventStart was rate-limited for that, but it I was thinking of singletap (but separated the commits just in case). Feel free to grab the other commit or reimplement as you see fit.

— Reply to this email directly or view it on GitHub.

sourcebits-robertbiggs commented 10 years ago

By the way, the singletap is the event to use for interactions in your app, instead of clicks. It’s only a 130 milliseconds delay, 1/3 faster than a click. And it still allows the user to touch and scroll on interactive elements. $.eventStart is a mousedown on desktop, touchstart on iOS and Android and MSPointerDown on Windows Phone.

On Dec 1, 2013, at 8:22 PM, Tom McKenzie notifications@github.com wrote:

Ahhh my misunderstanding, I was under the impression that $.eventStart was rate-limited for that, but it I was thinking of singletap (but separated the commits just in case). Feel free to grab the other commit or reimplement as you see fit.

— Reply to this email directly or view it on GitHub.