search

sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
617 stars 88 forks source link

Fix $.UIGoToArticle $.UINavigationHistory update #38

Closed sandwichfeet closed 10 years ago

sandwichfeet commented 10 years ago

UIGoToArticle wasn't setting the correct destination id in UINavigationHistory. Added the '#' to stop the back button from breaking.

sourcebits-robertbiggs commented 10 years ago

You must have something odd going on with your article ids. The value of destinationID is set with a hash on line 135 of navigation.js. Your addition will result in two hashes on each entry in $.UINavigationHistory. Try putting this in UIGoToArticle somewhere after line 137, or after your patch: console.log(destinationID) to see what is happening with your article ids.

By the way, if you have some way of sharing code, I'd be happy to help your troubleshoot this. We could do a screenshare on Skype.

sandwichfeet commented 10 years ago

Yep. Sorry I've added this from a previous version. Didn't see you'd fixed in this one. Please ignore.

sourcebits-robertbiggs commented 10 years ago

Thank you for using ChocolateChip-UI and for your enthusiasm to improve it.