Closed sandwichfeet closed 10 years ago
sandwichfeet
commented
10 years ago Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
sourcebits-robertbiggs
commented
10 years ago Hmmm… That is different. Give me a little bit of time here to play with the the navigation functions to see if I can come up with a better solution that will work for that scenario.
By the way, I’m working right now on a better solution for the Windows carriage return issue. I usually just use Git in the command prompt on Windows. And i use Visual Studio or Sublime Text 3. Both of these will not mess with the new lines. It’s only the Github Windows app that changes the line endings. However, I did notice that when running Grunt on Windows, when creating banners with newline markers “\n” these automatically become CRLF on Windows.
There are a couple of Git commands you can run to make the repository not check in carriage returns during a commit:
git config core.eol lf git confit core.autocrlf input
The first line will prevent the Github Windows app from converting the Unix new lines into Windows carriage returns. The second command will tell the Github app to convert Windows carriage returns into Unix new lines.
You run these in the directory.
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 9:22 AM, sandwichfeet notifications@github.com wrote:
Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
— Reply to this email directly or view it on GitHub.
sandwichfeet
commented
10 years ago Thanks Robert. There's no hurry from my end as what I have so far is working. It's only if I ever update chui.
I have a few of these small tweaks I needed to make when building the app, most of them are possibly because I started with 3.0.1
Would you prefer I raise them here as issues?
On Sun, Jan 12, 2014 at 5:32 PM, sourcebits-robertbiggs < notifications@github.com> wrote:
Hmmm… That is different. Give me a little bit of time here to play with the the navigation functions to see if I can come up with a better solution that will work for that scenario.
By the way, I’m working right now on a better solution for the Windows carriage return issue. I usually just use Git in the command prompt on Windows. And i use Visual Studio or Sublime Text 3. Both of these will not mess with the new lines. It’s only the Github Windows app that changes the line endings. However, I did notice that when running Grunt on Windows, when creating banners with newline markers “\n” these automatically become CRLF on Windows.
There are a couple of Git commands you can run to make the repository not check in carriage returns during a commit:
git config core.eol lf git confit core.autocrlf input
The first line will prevent the Github Windows app from converting the Unix new lines into Windows carriage returns. The second command will tell the Github app to convert Windows carriage returns into Unix new lines.
You run these in the directory.
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 9:22 AM, sandwichfeet notifications@github.com wrote:
Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/sourcebitsllc/chocolatechip-ui/pull/39#issuecomment-32127887 .
sourcebits-robertbiggs
commented
10 years ago Oh, I see. Yeah, we’re constantly working on fixing bugs that we and others find, and just generally trying to improve the API.
One thing, I’ve spent the last hour and a half trying to figure out a navigation flow that worked with back navigation, but I’m running to strange problems. I must be totally misunderstanding what your navigation flow is. I was thinking it was something like this:
User moves forward: article1 => article2 => article3 => article2 User moves back: article2 => article3 => article2 => article1
Is this right?
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 9:22 AM, sandwichfeet notifications@github.com wrote:
Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
— Reply to this email directly or view it on GitHub.
sourcebits-robertbiggs
commented
10 years ago So, I’ve committed some updates to navigation. This should cover your needs. Let me know.
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 10:45 AM, sandwichfeet notifications@github.com wrote:
Thanks Robert. There's no hurry from my end as what I have so far is working. It's only if I ever update chui.
I have a few of these small tweaks I needed to make when building the app, most of them are possibly because I started with 3.0.1
Would you prefer I raise them here as issues?
On Sun, Jan 12, 2014 at 5:32 PM, sourcebits-robertbiggs < notifications@github.com> wrote:
Hmmm… That is different. Give me a little bit of time here to play with the the navigation functions to see if I can come up with a better solution that will work for that scenario.
By the way, I’m working right now on a better solution for the Windows carriage return issue. I usually just use Git in the command prompt on Windows. And i use Visual Studio or Sublime Text 3. Both of these will not mess with the new lines. It’s only the Github Windows app that changes the line endings. However, I did notice that when running Grunt on Windows, when creating banners with newline markers “\n” these automatically become CRLF on Windows.
There are a couple of Git commands you can run to make the repository not check in carriage returns during a commit:
git config core.eol lf git confit core.autocrlf input
The first line will prevent the Github Windows app from converting the Unix new lines into Windows carriage returns. The second command will tell the Github app to convert Windows carriage returns into Unix new lines.
You run these in the directory.
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 9:22 AM, sandwichfeet notifications@github.com wrote:
Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/sourcebitsllc/chocolatechip-ui/pull/39#issuecomment-32127887 .
— Reply to this email directly or view it on GitHub.
sandwichfeet
commented
10 years ago Fantastic. Thanks again.
User moves forward: article1 => article2 => article3 => article2 User moves back: article2 => article3 => article2 => article1
Yes, that's right. I think the changes should cover it. I'll try updating my copy and check.
No worries about bugs. I think that's part of the reason I've enjoyed tinkering with this so much as I've been able to tweak the core to suit. It was only supposed to be a quick test app originally... It's a really nice little framework!
I'll try submit some more of these minor issues through on here later this week. Unless there is a better place to do so?
On Sun, Jan 12, 2014 at 8:15 PM, sourcebits-robertbiggs < notifications@github.com> wrote:
Oh, I see. Yeah, we’re constantly working on fixing bugs that we and others find, and just generally trying to improve the API.
One thing, I’ve spent the last hour and a half trying to figure out a navigation flow that worked with back navigation, but I’m running to strange problems. I must be totally misunderstanding what your navigation flow is. I was thinking it was something like this:
User moves forward: article1 => article2 => article3 => article2 User moves back: article2 => article3 => article2 => article1
Is this right?
Product Director ChocolateChip-UI
San Francisco
On Jan 12, 2014, at 9:22 AM, sandwichfeet notifications@github.com wrote:
Sorry, I didn't phrase that very well.
I'm using UIGoToArticle to navigate to an article that has a class of 'previous'. Which results in a blank page.
I want keep the navigation history intact though, so UIGoBackToArticle doesn't work for me. This fixes that.
I can send you what I have, but it's useless without the server backend. If you're interested I'd be happy to demo via skype as suggested previously.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/sourcebitsllc/chocolatechip-ui/pull/39#issuecomment-32132535 .
When navigating back to an article that was previously navigated away from. The destination may contain a 'next' class. This results in a blank screen as the article contains both a next and current class.
This change removes both previous and next classes from the destination.