sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
617 stars 88 forks source link

Back button rendering as oval on wp8 when in portrait orientation #48

Closed racingcow closed 10 years ago

racingcow commented 10 years ago

Hello all, and first of all thanks for the awesome library.

I am having a bit of trouble using chui v3.5.2 on Windows Phone 8. I have built everything with gulp according to the docs, and the demo screens show up with a "oval" back button in both the Windows Phone 8 emulator and on a Lumia 920 phone.

Upon further inspection, it looks like the issue only occurs when the phone (or emulator) is in portrait mode.

Here is a screenshot of the "Segmented Control" page in the emulator in portrait orientation...

image

...and here it is in landscape orientation...

image

I've also got a StackOverflow post that I created a few days back. It has a sample that will also reproduce the issue.

I have been able to reproduce this with the demo website in the latest package on npm, and by pulling the latest off of the master branch and building that code.

sourcebits-robertbiggs commented 10 years ago

Actually, that is not happening on my Lumia 928, but it is happening on my Lumia 620. That appears to be a problem with the viewport. I’m currently busy with preparations for a conference next week. I should have a fix checked in at latest by next Friday. For now I’d ignore this and wait for me to post the fix. I’ll let you know when I check it in. I just need to work out a proper media query and viewport configuration for devices with small screen sizes like the Lumia 620. That basically the same screen size as the older iPhone 3GS and 4.

Robert Biggs Product Director ChocolateChip-UI www.sourcebits.com

(415) 288-3697 Sourcebits, Inc. 211 Sutter Street. STE 200 San Francisco, CA 94108

On Feb 21, 2014, at 3:08 PM, David Miller notifications@github.com wrote:

Hello all, and first of all thanks for the awesome library.

I am having a bit of trouble using chui v3.5.2 on Windows Phone 8. I have built everything with gulp according to the docs, and the demo screens show up with a "oval" back button in both the Windows Phone 8 emulator and on a Lumia 920 phone.

Upon further inspection, it looks like the issue only occurs when the phone (or emulator) is in portrait mode.

Here is a screenshot of the "Segmented Control" page in the emulator in portrait orientation...

...and here it is in landscape orientation...

I've also got a StackOverflow post that I created a few days back. It has a sample that will also reproduce the issue.

I have been able to reproduce this with the demo website in the latest package on npm, and by pulling the latest off of the master branch and building that code.

— Reply to this email directly or view it on GitHub.

racingcow commented 10 years ago

Thanks for taking a look at this, @sourcebits-robertbiggs . I'll sit tight for now and test it after you get the fix in.

sourcebits-robertbiggs commented 10 years ago

This has been fixed in commit: 7641bd7b57

racingcow commented 10 years ago

I tested this morning, and verified that it is fixed in the wp8 emulator...

image