sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
616 stars 88 forks source link

UISelectList items aren't checked properly #54

Closed damianharvey closed 10 years ago

damianharvey commented 10 years ago

The current chui.js uses attr("checked", "checked") to check radio inputs for the UISelectList. This is incorrect as causes the radio button not to be selected (Chrome/Safari).

The correct way (as per jQuery website) is using the prop("checked", true) See: http://api.jquery.com/prop/#prop2

CodePen showing problem (click around a bit. See serialized form output.) http://codepen.io/damianharvey/pen/oCxne

This is with fix in using prop(): http://codepen.io/damianharvey/pen/KAEmL/

I've issued a pull request.

Thanks

sourcebits-robertbiggs commented 10 years ago

Yup. That's because before I used my own JavaScript library to handle that. But when I switched over to jQuery, I forgot about its inability to set the checked state with the attar() method and instead needed prop(). There were so many things I needed to change that this one slipped through the cracks. Thanks for contacting us about it.