search

sourcebitsllc / chocolatechip-ui

Mobile Web App Framework
www.chocolatechip-ui.com
MIT License
616 stars 88 forks source link

Gulpfile #72

Closed willywongi closed 10 years ago

willywongi commented 10 years ago

I found a couple of minor issues in the gulpfile. I can't see why the build process produces two folders: chui and dist: can't we just have one?

sourcebits-robertbiggs commented 10 years ago

Actually, the dist folder is there automatically, no build required. Quite a few users asked for a way to get the built version of themes and chui.js without having to build. So that’s why there’s dist. If you want to have examples, demos, etc., you’ll need to build. Since you might make changes to the source files for bug fixes, new features, branding changes to themes, the build puts that in the chui folder and the examples, etc., link to those.

Hope that clears things up for you.

Robert Biggs Product Director ChocolateChip-UI www.sourcebits.com

(415) 288-3697 Sourcebits, Inc. 211 Sutter Street. STE 200 San Francisco, CA 94108

On Jun 13, 2014, at 6:02 AM, willywongi notifications@github.com wrote:

I found a couple of minor issues in the gulpfile. I can't see why the build process produces two folders: chui and dist: can't we just have one?

You can merge this Pull Request by running

git pull https://github.com/willywongi/chocolatechip-ui gulpfile Or view, comment on, or merge it at:

https://github.com/sourcebitsllc/chocolatechip-ui/pull/72

Commit Summary

Removed duplicate "require" (gulp-jshint, gulp-header) Now all references to target directories are "chui/" and "dist/". CSS Minification was duplicated causing all files in "dist" directory to be minifcated (both .css and -min.css). File Changes

M gulpfile.js (15) Patch Links:

https://github.com/sourcebitsllc/chocolatechip-ui/pull/72.patch https://github.com/sourcebitsllc/chocolatechip-ui/pull/72.diff — Reply to this email directly or view it on GitHub.

willywongi commented 10 years ago

Perfectly clear! As soon as you review my changes please let me know if they're all right; I'd really love to give my help. Ciao!

sourcebits-robertbiggs commented 10 years ago

Actually, those were some good catches, especially the minifycss one. Not sure how that one slipped by.

sourcebits-robertbiggs commented 10 years ago

Hey willy, I accidentally merged your pull request on a different branch. It's late at night and I'm tired. I manually entered your Gulp patches to the master branch. The other branch is going to be merge in a few days any way, so no edit history will be lost. Just letting you know.

willywongi commented 10 years ago

Okay, no worries.