sourcebots / marker-to-pdf

Script to convert a directory of markers to pdfs
MIT License
0 stars 1 forks source link

Repo Duplication? #2

Open RealOrangeOne opened 6 years ago

RealOrangeOne commented 6 years ago

This repo seems highly related to https://github.com/sourcebots/tag-inflator. Whilst I think this work shouldve been done extending that script, that's another story.

If we're planning on using this repo / script to ship marker PDFs, I think we should import any functionality from the other script, and delete its repo.

Missing Features

PeterJCLaw commented 6 years ago

If the repos are indeed duplicated, I'd be slightly in favour of keeping tag-inflator as it already has most of the things you've outlined that we want. While it outputs SVG rather than PDFs, the conversion from SVG to PDF is pretty trivial (in the simplest case it's a one-line inkscape call).

ninjafrostpn commented 6 years ago

Sorry, I shouldn't have made marker-to-pdf as a new standalone thing, I should have taken the time to understand tag-inflator. But... how does tag-inflator work? How do you use it? (also what is inkscape?) I started making something to put markers into pdf documents because we needed this at the time, it was annoying to do by hand, and I couldn't make heads or tails of tag-inflator, so made something simple.

PeterJCLaw commented 6 years ago

http://www.inkscape.org/ is a vector-graphics program for working with SVG files. When run as a command-line tool (rather than the full GUI) it can convert SVG files to a number of output formats, including PDF.

PeterJCLaw commented 6 years ago

Hrm, it looks like tag-inflator does indeed output PDFs too.

PeterJCLaw commented 6 years ago

Hrm, so from what I can see, tag-inflator doesn't have a mechanism to specify the size to inflate the marker to, while this repo's script does.

PeterJCLaw commented 6 years ago

tag-inflator has the advantage that the code is well separated from the input handling, so should be easy to modify to handle scaling as need (the current scaling seems to be somewhat magical)

ninjafrostpn commented 6 years ago

Aha. I had no idea that you could run tag-inflator from the commandline :) Anton explained and now it makes sense how to use it (but I had to use the python35 branch). Apologies for my ignorance, tag-inflator works perfectly well and can probably quite easily be turned to the intended application of marker-to-pdf, as you have said. I'll set to writing a README for that also.