search

sourcebroker / imageopt

TYPO3 extension imageopt. Optimize images resized by TYPO3 so they will take less space, page will be downloaded faster and Google PageSpeed Insights score will get higher.
Other
31 stars 8 forks source link

Best Result is not taken #10

Closed walderT closed 7 years ago

walderT commented 7 years ago

I found a problem if the second iteration result gets the same bytes as the original image.

Look here: https://github.com/sourcebroker/imageopt/blob/63a744fdd216fd16c0626503b325f48aaf018e39/Classes/Service/ImageManipulationService.php#L161-L162

The first condition mets in this case, because the $theBestOptimizedImage is the empty tempfile defined in $theBestOptimizedImage = $this->createTempFile(); https://github.com/sourcebroker/imageopt/blob/63a744fdd216fd16c0626503b325f48aaf018e39/Classes/Service/ImageManipulationService.php#L152

kszymukowicz commented 7 years ago

Please check to 1.0.0 version released today as its complete rewrite and probably this problem is fixed there.

kszymukowicz commented 7 years ago

I am closing this issue because no response.