search

sourcebroker / imageopt

TYPO3 extension imageopt. Optimize images resized by TYPO3 so they will take less space, page will be downloaded faster and Google PageSpeed Insights score will get higher.
Other
31 stars 8 forks source link

[BUGFIX] Prevent PHP fatal error about missing abstract #12

Closed frans-beech-it closed 7 years ago

frans-beech-it commented 7 years ago

In PHP7 you can only extend classes with abstract methods that are abstract them selfs.

kszymukowicz commented 7 years ago

Just FYI (and its not connected to this issue).

I am working currently on refactor of imageopt with no services because services has no so much sense here as anyway almost all services (providers) are run and the best optimized image choosen. Whereas as I understand the services and services priority is to select the best service for doing some thing - this is not the case here.

The new work is done in "no_services" branch.

For new feature there will be possiblity to join few optimizers to work after each other. 

pngquant-pngcrush {
                executors {
                    10 < tx_imageopt.providers.png.pngquant.executors.10
                    20 < tx_imageopt.providers.png.pngcrush.executors.10
                }
            }

Take a look at full TSconfig proposal: https://github.com/sourcebroker/imageopt/blob/no_services/Configuration/TsConfig/Page/tx_imageopt.tsconfig

Branch "no_services" is not working yet fully.