search

sourcefabric / Newscoop

Newscoop is the open content management system for professional journalists. Features for the modern newsroom include multiple author management, issue-and-section based publishing, geolocation and multilingual content management. The enterprise-standard journalist’s dashboard and a templating engine supporting anything from HTML5 to mobile complete this fast production and publishing system.
http://newscoop.sourcefabric.org
GNU General Public License v3.0
251 stars 146 forks source link

remove not needed community ticker command #1377

Closed takeit closed 8 years ago

takeit commented 8 years ago

Since version 4.3.0 we have moved community ticker from the plugin to the Newscoop core. The following command should be removed, because if you run it in Newscoop version >=4.3.0 it will delete the whole community_ticker_events table, thus the Newscoop will crash.

ahilles107 commented 8 years ago

But we still support upgrade from 4.2 in 4.4 so it should stay and be fixed if it creates issues.

takeit commented 8 years ago

but in 4.2 the table name is: community_ticker_event and from 4.3.0 it's also the same name, this command was only needed when you had the community ticker installed as a plugin so you could move content from community_ticker_event (and delete afterwards) to plugin_community_ticker_event, thats why it is not needed anymore imo

ahilles107 commented 8 years ago

So what should do people who have 4.2 with plugin installed and they want to upgrade to 4.4 and keep all community data?

takeit commented 8 years ago

uninstall the plugin first but then it will remove the community_ticker_event table, because the plugin is using the same table name which is: community_ticker_event - I just checked, it is not plugin_community_ticker_event.

So an option is: before plugin uninstall, run command which will create temp table (e.g. community_ticker_event_temp) where it will copy to all the data from community_ticker_event table, remove it and rename community_ticker_event_temp back to community_ticker_event, but not sure if it is worth it or just do this all manually in mysql?

This is the same issue with the xnewswire table in ingest plugin that we have. Anyway we need a proper solution here or a clear guide for users on how to proceed with such use case.