sourcefuse / loopback4-authentication

A loopback-next extension for authentication feature. Oauth strategies supported.
https://www.npmjs.com/package/loopback4-authentication
MIT License
73 stars 33 forks source link

fix(component): make client password and bearer strategy as mandatory #210

Closed sf-sahil-jassal closed 9 months ago

sf-sahil-jassal commented 9 months ago

make bearer strategy non optional, resulting client password strategy also not optional

GH-209

Description

Making the bearer strategy mandatory. But, by only making the bearer as manadatory, failed in test cases. Seems like, client password strategy is also needed for the same (infact all strategies as client is always needs to be authenticated first). So, I also made client password strategy as mandatory.

Fixes #209

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

yeshamavani commented 9 months ago

:tada: This PR is included in version 11.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: