fix(sandbox): build sandbox docker-compose file without error - Githubissues

sourcefuse / loopback4-microservice-catalog

A Catalog of Microservices Created by SourceFuse for the Community

https://sourcefuse.github.io/arc-docs/arc-api-docs/

MIT License

296 stars 72 forks source link

fix(sandbox): build sandbox docker-compose file without error #2067

Closed arpit1503khanna closed 3 months ago

arpit1503khanna commented 7 months ago

Description

Build sandbox docker-compose file without error

Fixes #1969

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

yeshamavani commented 6 months ago

@a-ganguly @arpit1503khanna is anything pending here ?

yeshamavani commented 6 months ago

@arpit1503khanna please resolve these conflicts and rebase the PR

yeshamavani commented 3 months ago

Raising a fresh PR too many conflicts since this is old https://github.com/sourcefuse/loopback4-microservice-catalog/pull/2132