@sourceloop/cli: Missing dependencies in some facades and services - Githubissues

sourcefuse / loopback4-microservice-catalog

A Catalog of Microservices Created by SourceFuse for the Community

https://sourcefuse.github.io/arc-docs/arc-api-docs/

MIT License

298 stars 72 forks source link

@sourceloop/cli: Missing dependencies in some facades and services #2218

Open rohitvishwakarma-sf opened 1 week ago

rohitvishwakarma-sf commented 1 week ago

Describe the bug

Some dependecies were no installed by default in auth-facade, authentication-service and audit-service. Despite this when setup was created after npm i everything was working fine. But when i clean all node_modules and root package-lock.json. Mentioned facades started throwing error for below dependencies.

AuthFacade

"@opentelemetry/api": "^1.9.0",
"@types/mocha": "^10.0.10", (dev dependency)

AuditService

"@aws-sdk/client-s3": "^3.699.0",
"@hapi/shot": "^6.0.1",
"@sinonjs/commons": "^3.0.1",
"aws-sdk": "^2.1692.0",
"cookiejar": "^2.1.4",
"csvtojson": "^2.0.10",
"dezalgo": "^1.0.4",
"oas-validator": "^5.0.8",
"should": "^13.2.3",

AuthenticaionService

"base-64": "^1.0.0",
"bcrypt": "^5.1.1",
"cookie-parser": "^1.4.7",
"node-forge": "^1.3.1",
"otplib": "^12.0.1",
"qrcode": "^1.5.4",

In all facade and service

"@sinonjs/commons": "^3.0.1"

To Reproduce Steps to reproduce the behavior:

Create a project with auth-facade, authentication-service and audit-service.
setup npm workspaces
Delete package-lock.json file and all node_modules
run npm i
run npm build or npm start or npm test

Expected behavior

Requred dependecies should be added explicitly.

Additional context

shouldn't aws related dependencies be optional in audit-service ?