SFO-4 Added user controller and login controller test cases - Githubissues

sourcefuse / loopback4-starter

Loopback 4 starter application. Multi-tenant architecture supported. Authentication, Authorization, Soft deletes, environment vars, Audit logs, included.

MIT License

158 stars 59 forks source link

SFO-4 Added user controller and login controller test cases #44

Closed IshuSF closed 4 years ago

IshuSF commented 4 years ago

Description

Added Unit test cases for the User Controller and Login Controller.
Added create function in user_tenant repository to fix the bug where a newly created user tries to get its bearer token using auth/token API. Previously there was no user_tenant record found in the database corresponding to a user record in the createJWT function.

Fixes #43 , #42 , #36

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested ?

[x] Using the npm test, I verified that all the test cases are successful.
[x] Successfully got the Bearer token of a newly created user.

Checklist :

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[x] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide
[ ] API Documentation in code was updated

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication