sourcefuse / terraform-aws-arc-db

Repo for managing the Database (RDS + Aurora) Terraform Module.
Apache License 2.0
2 stars 1 forks source link

'performance_insights_kms_key_id' attribute to handle default CMK usage #55

Closed mayank0202 closed 9 months ago

mayank0202 commented 9 months ago

Currently This attribute is using the default rds kms key and also there is a resource of kms creation for aurora and rds so if you create aurora then it will create a CMk for you and by default it will use rds and cannot be changed because there is no variable for performance attribute and there is no use of that CMK which is being created by module so either remove that kms key creation for aurora and use target key arn of default rds kms with data lookups and make a variable of performance attribute and also add a condition so that anyone wants to override this value with its own CMK can do it as well.

Second option is to remove data lookups for defult rds kms key and to make performnace attribute conditional like if this value is null then it will use the CMK key which is created by module and if its not null then definitely it will be using that Key whichever enduser have provided