search

sourcefuse / terraform-aws-arc-ecs

Repo for managing the ECS Fargate Terraform Module.
Apache License 2.0
1 stars 3 forks source link

Add KMS CMK support #62

Open tsaucier-sf opened 3 months ago

tsaucier-sf commented 3 months ago

Is your feature request related to a problem? Please describe. Sometimes, we will want to create a CMK for the cluster resources, can we add this optional functionality to the module?

Describe the solution you'd like Add KMS CMK creation for the deployed cluster

AsysGuptaSF commented 1 month ago

What part of the cluster has to be encrypted with CMK? @mayank0202

tsaucier-sf commented 1 month ago

What part of the cluster has to be encrypted with CMK? @mayank0202

@AsysGuptaSF, anywhere it is supported this feature should be available. Something similar to what we do here by overriding a default value with something the downstream defines.

mayank0202 commented 1 month ago

What part of the cluster has to be encrypted with CMK? @mayank0202

@AsysGuptaSF, anywhere it is supported this feature should be available. Something similar to what we do here by overriding a default value with something the downstream defines.

we can use module arc-kms for this and override can be done @tsaucier-sf

tsaucier-sf commented 1 month ago

What part of the cluster has to be encrypted with CMK? @mayank0202

@AsysGuptaSF, anywhere it is supported this feature should be available. Something similar to what we do here by overriding a default value with something the downstream defines.

we can use module arc-kms for this and override can be done @tsaucier-sf

Sure, still need the option available to the cluster and its resources. Default can be none, then the override variable to set a CMK as an input to the referenced module.