search

sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
668 stars 69 forks source link

Added ability to run program by default for macOS and Linux #107

Closed dangreene0 closed 2 months ago

dangreene0 commented 2 months ago

By default the compiled program will not run on macOS or Linux and the user must use chmod to enable the ability to execute.

By adding another step in the jobs for macOS and Linux the artifact will now run when the user downloads.

c7784b0

dangreene0 commented 2 months ago

Thanks for the merge!

After testing this, it seems to not have worked and is probably a perms issue. I will possibly look into it more and test it before following up with another PR.

gadfly3173 commented 2 months ago

actions/upload-artifact@v4 will package product files into zip, and zip does not support permission management. To solve this problem, you need to package it yourself through tar. https://github.com/actions/upload-artifact#permission-loss

- name: 'Tar files'
  run: tar -cvf my_files.tar /path/to/my/directory

- name: 'Upload Artifact'
  uses: actions/upload-artifact@v4
  with:
    name: my-artifact
    path: my_files.tar
dangreene0 commented 2 months ago

actions/upload-artifact@v4 will package product files into zip, and zip does not support permission management. To solve this problem, you need to package it yourself through tar. https://github.com/actions/upload-artifact#permission-loss

- name: 'Tar files'
  run: tar -cvf my_files.tar /path/to/my/directory

- name: 'Upload Artifact'
  uses: actions/upload-artifact@v4
  with:
    name: my-artifact
    path: my_files.tar

Thanks for the reply. I found this out through a Post on StackOverflow and I'm working on a PR shortly.

It sure is a strange quirk!