search

sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
668 stars 69 forks source link

Close Tab Enhancement #115

Closed ennerperez closed 2 months ago

ennerperez commented 2 months ago
love-linger commented 2 months ago

It is write on purpose, see code in ViewModels/Launcher.cs at line 106:

public void CloseTab(object param)
{
    if (Pages.Count == 1)
    {
        App.Quit();
        return;
    }

    // ...
}

It's a common behaviour on multi-tabs apps like Chrome.

ennerperez commented 2 months ago

Any other example Chrome is not good example, Browser like Opera don-t allow to close all tabs same for Thunderbrid. But this app is not a web brower, is anoying to re open the app when no tabs.

love-linger commented 2 months ago

First, as I said, it's feature that write on purpose, not a bug. Second, your PR just works in the way that looks like as a BUG.

I'll implement this feature myself. The behaviour of closing the last tab of this app will be changed to: