sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
668 stars 69 forks source link

Questions about the repository search filter #117

Closed gadfly3173 closed 2 months ago

gadfly3173 commented 2 months ago

Welcome._searchFilter saves value on each welcome page, however, the Welcome.SetVisibilityBySearch method is used to assign a value to RepositoryNode.IsVisible to control whether to display it. RepositoryNode is loaded through Preference.Instance.RepositoryNodes in Welcome, so RepositoryNode and its display status are in all Shared on the Welcome page. This results in SearchFilter possibly having different values but the same search results in different Welcome pages. For example, after searching in a Welcome page and then opening a Welcome page, there is input in the search box of the first one but not in the second one, but the second Welcome page still displays the previous search results.