search

sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
1.14k stars 112 forks source link

ux: get brush color for LineBackgrounRenderer from themes #166

Closed ccyr119 closed 4 months ago

love-linger commented 4 months ago
  1. In my opinion, the Windows background color provided by this PR is too low in contrast, resulting in the overall gray. image
  2. The new color schema in LineBackgroundRenderer does not fit well with the Light theme image The original color schema looks like this image
ccyr119 commented 4 months ago
  1. High contrast color schema will results in eyestrain.

image

  1. New color schema for ResourceLineBackgroundRenderer changed to use Themes resource dictionary, and support both Dark and Light appearance.

image

love-linger commented 4 months ago

I've pushed a commit 62e5ed8a42f871c02b07b23f24de5753fe09014a that allows user overrides default color theme with a json file. For example:

{
   "Color.FG1": "#FF00FF00"
}

This file will change the Foreground color for the current active theme.