search

sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
616 stars 66 forks source link

Dragging the border to resize the window looks weird #177

Closed gadfly3173 closed 3 weeks ago

gadfly3173 commented 3 weeks ago

https://github.com/sourcegit-scm/sourcegit/assets/28685179/86674e12-fb32-4a19-9afa-1b1d1c4d5feb

It looks like dragging only works when the mouse is inside the window. When the mouse position exceeds the window, the icon becomes draggable, but the window border cannot be dragged.

love-linger commented 3 weeks ago

Commit d9e17b9 works fine on my Debian 12 (Wayland). Look forward to your feedback.

gadfly3173 commented 3 weeks ago

Looks good on Deepin 20.9 . But Commit 762ec1f702538dd51dfb474c1197d48910352a2d doesn't look right, the problem before I modified the BeginMoveWindow method reappeared. The problem occured after moved window once.

https://github.com/sourcegit-scm/sourcegit/assets/28685179/7678b78c-7477-43c0-a7cc-95bc686b2ccf

love-linger commented 3 weeks ago

I can not reproduce the issue in your video on Debian 12.

https://github.com/sourcegit-scm/sourcegit/assets/4075673/99978a2b-ed9c-49b2-a356-62dd1cd41ba4

gadfly3173 commented 3 weeks ago

I have only found this problem in the DDE desktop environment. I will try to fix it when I have time tomorrow.

love-linger commented 3 weeks ago

In fect, commit 762ec1f702538dd51dfb474c1197d48910352a2d is intended to solve the issue your video shows.

With this commit, double-click should not trigger the move-window action, because it has no mouse move delta.

I'll push anthor commit to make sure that _pressedTitleBar is false while double-click action taking place.

gadfly3173 commented 3 weeks ago

Commit 13cc494 seems to be working fine.