search

sourcegit-scm / sourcegit

Windows/macOS/Linux GUI client for GIT users
MIT License
610 stars 66 forks source link

Low/inconsistent default themes contrast #232

Closed Shimoon closed 3 days ago

Shimoon commented 3 days ago

Some contrasts in the default themes make hard to see whats going on.

History tabs

Is is a bit hard to understand which tab is selected if not for the underline. sourcegit_dark_tabs While the light theme makes it pretty obvious though : sourcegit_light_tabs

Changes tab (right side buttons)

Here, syntax highlighting and side-by-side diff are both enabled while line word wrap and show hidden symbols are disabled. sourcegit_dark_buttons If we keep the increase/decrease context lines buttons logic (dark theme), lighted should be active while dimmed should be inactive. The issue here gets even worse using the light theme, the contrast remain basically the same activated or not : sourcegit_light_buttons

Dashboard / Search

Either with the dark theme or light one, the active button is dimmed which makes it visually inactive for the user : sourcegit_dark_dashboard-search sourcegit_light_dashboard-search

It may be good to have some sort of consistent guideline for both default themes that implies that selected/actif items should be the more visibles ones to avoid any confusion.

Previous Source Git versions had blue tint for actives items that was actually pretty nice to understand quickly what was enabled or not.

love-linger commented 3 days ago

The accent color is depends on your system. For example, on Windows, you can change accent color from image

love-linger commented 3 days ago

https://github.com/sourcegit-scm/sourcegit/assets/4075673/783c561a-7724-4b6e-9a58-ee1382c49784

Shimoon commented 3 days ago

Oh that makes sense now, mine is set to dark grey ! While this is pretty nice, wouldn't it be preferable to have a toggle option for that ? And a fallback color if disabled - or the ability to set a custom one if we want to go crazy :) ?

love-linger commented 3 days ago

you can use custom themes from https://github.com/sourcegit-scm/sourcegit-theme/tree/develop

love-linger commented 3 days ago

a new key SystemAccentColor was added to customize the accent color. Remember use the themes in develop branch with latest sourcegit app build from https://github.com/sourcegit-scm/sourcegit/actions/runs/9764518339