search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Investigate flaky CI test #101

Closed slimsag closed 8 years ago

slimsag commented 8 years ago

Every once in awhile Travis CI fails due to a flaky test, we should investigate why this is. It seems that most PRs fail due to this right off the bat, but requeuing the build seems to fix it.

chris-ramon commented 8 years ago

I've seen TestChunkedCollector failing locally intermittently as well - logs:

(appdash) -> go version
go version go1.5.2 darwin/amd64
(appdash) -> go test ./...
--- FAIL: TestChunkedCollector (0.04s)
    collector_test.go:215: after MinInterval: got packets == [SpanID{trace:2 span:3 parent:4 } Annotation{key:"k3" value:"v3" }  SpanID{trace:1 span:2 parent:3 } Annotation{key:"k1" value:"v1" } Annotation{key:"k2" value:"v2" } Annotation{key:"k4" value:"v4" } ], want [SpanID{trace:1 span:2 parent:3 } Annotation{key:"k1" value:"v1" } Annotation{key:"k2" value:"v2" } Annotation{key:"k4" value:"v4" }  SpanID{trace:2 span:3 parent:4 } Annotation{key:"k3" value:"v3" } ]
FAIL
FAIL    sourcegraph.com/sourcegraph/appdash 2.312s
?       sourcegraph.com/sourcegraph/appdash/cmd/appdash [no test files]
?       sourcegraph.com/sourcegraph/appdash/examples/cmd/webapp [no test files]
ok      sourcegraph.com/sourcegraph/appdash/httptrace   0.022s
?       sourcegraph.com/sourcegraph/appdash/internal/wire   [no test files]
?       sourcegraph.com/sourcegraph/appdash/sqltrace    [no test files]
?       sourcegraph.com/sourcegraph/appdash/traceapp    [no test files]
?       sourcegraph.com/sourcegraph/appdash/traceapp/tmpl   [no test files]