search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

add queueSize parameter to ChunkedCollector.OnFlush #112

Closed slimsag closed 8 years ago

slimsag commented 8 years ago

This enables us to debug what appears to be a queue buildup causing Flush operations to take much longer and eventually leak memory.

dmitshur commented 8 years ago

There's a build failure on line 113:

./collector.go:113: not enough arguments in call to cc.OnFlush

Edit: Never mind, you've just fixed it.

dmitshur commented 8 years ago

LGTM.

slimsag commented 8 years ago

@shurcooL thanks!