Closed slimsag closed 8 years ago
LGTM, but see comments.
LGTM
@shurcooL could you please review the new changes? I've added an upper bound to the queue size based on an (est.) amount of RAM usage per feedback from @neelance
In the process I've also clarified a lot of the documentation and made it more concrete, in addition to adding a NewChunkedCollector
method which picks the (generally) right defaults.
I've reviewed the changes since https://github.com/sourcegraph/appdash/pull/113#issuecomment-190560933, and you've addressed all my new comments. LGTM.
This change adds a FlushTimeout field to ChunkedCollector which can be used to prevent a large queue from building up within the ChunkedCollector, effectively leaking/consuming large amounts of memory, due to an misbehaving underlying collector (like RemoteCollector, which would attempt to reconnect to a flaky remote server upon each collection).
/cc @neelance @keegancsmith