Closed chris-ramon closed 8 years ago
Thanks for the prompt PR, but sadly I think this doesn't actually fix the issue but rather just addresses the symptoms of the issue.
InfluxDBStore should have no knowledge of httptrace.ClientEvent
trace tag prefix at all. I think the real issue here is most likely with how we are gathering the data back out of InfluxDB and reassembling the full trace. #117 and #118 might even be directly related.
I'll have time tomorrow to investigate and discuss the proper fix here further.
Definitely agree on having a better strategy on how we handle the reassemble part when building back annotations from InfluxDB fields, I've submitted a PR: #121 that works/handles it quite better.
Closing in favor of https://github.com/sourcegraph/appdash/pull/121
Details
Issue: #117
InfluxDB.Trace(...)
&InfluxDB.Traces(...)
to exclude certainAnnotations
from thetrace/traces
being returned:httptrace.Client
&InfluxDB
related annotations are excluded.InfluxDB
related annotations are excluded.