Improvements on `addChildren`.

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.

https://sourcegraph.com

Other

1.72k stars 137 forks source link

Closed chris-ramon closed 8 years ago

chris-ramon commented 8 years ago

Issue: #118 Built on top of: #124

[x] Adds tests for addChildren.
[x] Updates addChildren:
- Adds fallback for sub-traces which their parent was not found on trace root, so those sub-traces are added now to the trace root.

slimsag commented 8 years ago

I have left an inline comment regarding how to document this behavior better. This change seems correct, though. I'm excited to try this out!

slimsag commented 8 years ago

LGTM