search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

(long term) consider making OpenTracing API the primary interface #126

Open slimsag opened 8 years ago

slimsag commented 8 years ago

I've yet to try it out for real, but if the OpenTracing API turns out to be nice in real applications, we could in theory make Appdash just operate as if it was just an implementation of the OpenTracing API. I.e. there would not be an Appdash API, it would just be that Appdash is a tracer designed specifically for OpenTracing.

I've marked this issue as long-term, because this would be a serious change and would probably be done in multiple phases (unexporting the current API, simplification of the internals w.r.t marshaling events, etc). I'm also not 100% convinced yet that this would be most ideal or appropriate, but it is something I am considering longer term.

josephjacks commented 7 years ago

Any progress on this front? I am interested in this. I see the support of OT, but unsure how far you plan to take this and what the thought process is. cc @bensigelman

slimsag commented 7 years ago

Sorry, I haven't had a great deal of time to investigate this yet. I think that the first step in implementing this would be:

  1. Move all current Appdash code in sourcegraph.com/sourcegraph/appdash/... to sourcegraph.com/sourcegraph/appdash/internal/...
  2. Expose the most minimal OT API in the main package
  3. A slightly long-winded PR in which others chime in confirming it looks good :)

I probably won't have time to work on this for a while, but if someone wants to send a PR for the above I'll gladly review etc.