Closed chris-ramon closed 8 years ago
I'd vote for AggregateStore
not being removed, since one of the nice things about Appdash is that it can be embedded in an application without many dependencies, ie influxdb in this case.
I'd vote for AggregateStore not being removed, since one of the nice things about Appdash is that it can be embedded in an application without many dependencies, ie influxdb in this case.
Hi @bg451, thanks for giving ur thoughts about the AggregateStore being removed, would you mind continue the conversation about it in #127, this being is initial comment. This PR is just being build in top of it but it's main purpose is to improve the Recorder
.
LGTM
Let's def. move the AggregateStore conversation elsewhere.
Details
Related issue: https://github.com/sourcegraph/appdash/issues/132
Recorder.Finish(...)
method, such that a span will only be recorded to once (a recorder produces only oneStore.Collect(...)
call for a givenSpanID
).Recorder.Finish(...)
in order to collect the span.