search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Add support for a context menu that can show and hide specific spans. #16

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

Add support for a context menu that can show and hide specific spans.

By default, only the immediate children of the trace are visible, for example:

image

Instead of:

image

You can then right click (context menu button) on any timespan rectangle (e.g. Request) to bring up the context menu:

image

Clicking Show Children or Hide Children causes all immediate and distant children of that span to be hidden/shown. For example clicking Show Children on the Request span:

image

And then Hide Children on Moonuiburg:

image

slimsag commented 9 years ago

@beyang I believe you said not to, but just to be sure: I shouldn't make dist or make gen-dist after changes like this, correct?

beyang commented 9 years ago

yep, no need to run make dist or anything like that.

If you added any files to traceapp/tmpl, you'd have to run make gen-dev to regenerate the data.go file (but then it'd be obvious, because it would break on your local machine).

slimsag commented 9 years ago

yep, no need to run make dist or anything like that.

Okay, great. Just wanted to make sure I understood properly.

If you added any files to traceapp/tmpl, you'd have to run make gen-dev to regenerate the data.go file (but then it'd be obvious, because it would break on your local machine).

I see. Good to know. :smile: