Closed dominikh closed 8 years ago
Thanks for the PR!
This looks reasonable to me, but I'll let @slimsag take this because he's more familiar with the details of this project.
Mostly, I was interested in learning how this occurred. But I think I've found the answer to that.
From CHANGELOG.md:
- Apr 15, 2016 - Breaking Changes!
- #136 Users must now call
Recorder.Finish
when finished recording, or else data will not be collected.
It looks like PR #136 broke this by introducing that breaking change, but forgetting to update cmd/appdash/sample_data.go
.
LGTM, thank you @dominikh !
Indeed we should have been more careful in PR #136 -- my apologies for missing that during review!
If Finish isn't called, no data will ever be sent to the collector, rendering 'appdash send' ineffective.