search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Impossible to view a whole trace's graph at once #168

Open dominikh opened 8 years ago

dominikh commented 8 years ago

When looking at a trace (/traces/<id>), the graph only shows two spans (the root, and one child). Clicking on the child loads a new page that shows the child and its child. There is no way to view the entire trace's graph at once. Screenshot with example attached:

2016-05-08-131156_1380x802_scrot

dominikh commented 8 years ago

Worse, the current design if the UI doesn't allow for displaying the entire tree at once, because the tree structure isn't visible. If each span had more than one child, one couldn't tell which span belonged to which.

slimsag commented 8 years ago

Some clarification: Viewing a trace /traces/<id> shows the root span (host1 above) and all of its children. I can confirm this behavior as working with go run ./examples/cmd/webapp-influxdb/main.go which shows:

image

In your case, the root span host1 appears to have only one child span host2. Note that profile view shows all spans in the trace, so these two views should differ.

In response to the feature request of viewing all spans in a trace at once via this view, I agree it's a good idea.

dominikh commented 8 years ago

Yes, this is a feature request, not a bug report. I'm sorry if I wasn't clear enough about that.

slimsag commented 8 years ago

No trouble at all, my misunderstanding, and thank you for raising this issue 😄

solher commented 8 years ago

What would be the current good practice? Have one root span and flatten the span tree in multiple children or wait for the feature to be implemented and keep a full span tree?