search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Add OpenTracing Python implementation #169

Closed bg451 closed 8 years ago

bg451 commented 8 years ago

Now that https://github.com/opentracing/basictracer-python is a thing, I've added a python opentracing implementation for Python. What's really cool about this is that it's 100% compatible with the Golang implementation, so two processes can send each other spans and join traces using the inject/join methods.

I'm not too sure how python dependencies work(I'm not too great with python), but I changed setup.py to use setuptools to bring in the basictracer dependency.

bg451 commented 8 years ago

ping @slimsag

slimsag commented 8 years ago

This looks like a great improvement, thanks! I have one minor comment inline and will merge after it's addressed.

Sorry for the delay!

bg451 commented 8 years ago

Addressed your comment, should be good to go! @slimsag

slimsag commented 8 years ago

Thanks Brandon! 😃