search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

opentracing: Update package to use span contexts #174

Closed bg451 closed 8 years ago

bg451 commented 8 years ago

The concept of spancontexts were recently introduced with https://github.com/opentracing/opentracing.github.io/pull/100 and https://github.com/opentracing/basictracer-go/pull/29

Fixes #173

cc @slimsag @shurcooL

dmitshur commented 8 years ago

The rest looks reasonable to me, but I'm not closely familiar with open tracing API.

The CI is still failing because of some build error in github.com/influxdata/influxdb/services/httpd.

keegancsmith commented 8 years ago

The influxdb build failure seems to be a problem in upstream influxdb :/ https://github.com/influxdata/influxdb/issues/6924

I'm gonna merge this in just so that we fix build breakages for people not using influx.

keegancsmith commented 8 years ago

@bg451 thanks for fixing this!