Closed kelseyhightower closed 7 years ago
The good news: The build completes with Go 1.7. The bad news: The test fail, which I'm not sure is related to Go 1.7.
Hi @kelseyhightower ! Thanks for catching this and sending the PR!
I think given that < Go 1.7 support has become broken and nobody has complained, we can drop support for it in contrast to what I said previously in a separate PR https://github.com/sourcegraph/appdash/pull/178#issuecomment-252138517
LGTM -- and thank you! 😄
Appdash can no longer be built using Go 1.6 with implicit external dependencies. One or more upstream dependencies imports the "context" package from the Go 1.7 standard library which means Appdash must use Go 1.7 in order to build it. Using Go 1.6 causes the following build error when using Travis CI:
Resolve the issue by updating the Travis CI build configuration to use Go 1.7 as the minimum supported Go version.