Closed amitsaha closed 7 years ago
The PR #186 fixes your traceback.
About the 2nd "issue", I guess the recv
says the time of "closing" for the span.
PR #186 has been merged.
Re: 2nd issue -- it's true the recv
parameter says the time of closing for the span. You can see this in action here: https://github.com/sourcegraph/appdash/blob/master/python/example_socket.py#L32
Also, it defaults to the current time, meaning that you can omit it and just consider collection time to be the same as span closing time.
If you have more questions / suggestions please open a new issue :)
When I try to run
example_opentracing_socket.py
I get:I removed the parent
kwarg
and tried to assign the.parent
attribute, but it didn't set the relationship correctly.My second "issue" is a question:
Looking at
example_socket.py
, I don't see a span being finished or closed. A quick look at the Golang demo web app shows that a span is explicitly finished by a function call. How does a Python client application finish a span?