Before go introduced context into the stdlib, the sane way to track SpanID
across requests was via gorilla/context. gorilla/context works via
tracking the pointer value of a request in a map. However,
Request.WithContext returns a new pointer and is called via gorilla/mux. As
such our example app would insta-panic.
We introduce a new default behaviour which relies on the stdlib context. We
update all examples and documentation regarding the deprecation of
SetContextSpan.
Before go introduced context into the stdlib, the sane way to track SpanID across requests was via gorilla/context. gorilla/context works via tracking the pointer value of a request in a map. However,
Request.WithContext
returns a new pointer and is called via gorilla/mux. As such our example app would insta-panic.We introduce a new default behaviour which relies on the stdlib context. We update all examples and documentation regarding the deprecation of
SetContextSpan
.Fixes https://github.com/sourcegraph/appdash/issues/189