sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

a Span storage specification issue #207

Closed 1046102779 closed 6 years ago

1046102779 commented 6 years ago

Span type include SpanID and Annotations

I think SpanID is span's own informations, and Annotations data is other infos and these may be empty

but in OpenTracing specfications, span's Operation Name belong itself。so i think Span type's definition is not friendly enough.

but in Appdash , span's OperationName is in Annotations

keegancsmith commented 6 years ago

Note that appdash predates OpenTracing. We don't have any current plans on making major changes to the project or the wire format. I assume your issue here is minor and doesn't actually affect functionality? If not please re-open.

1046102779 commented 6 years ago

but Appdash use basictracer-go library, the basictracer follows OpenTracing specifications

keegancsmith commented 6 years ago

OT support is an extension, not core to appdash. You can log to appdash without using OT.