sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

traceapp: generate profile times that exactly match the timeline. #30

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

This change makes the profiling times be calculated as floating-point numbers and rounded up, as they are in the d3 timeline. This is both more accurate and less confusing to users overall.

With this change we also appropriately grab the largest of the timespan events, rather than just the first one. This matches how apptrace already sends the timespans to the template for rendering in the timeline.

Before (see incorrect profile vs timeline times):


image


After (see identical profile & timeline times):


image