search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Add optional ImportantEvent interface. #38

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

This change allows events to optionally implement the ImportantEvent interface. It enables events to return a list of annotation keys (e.g. Response.StatusCode) which thye find particularly important. Annotation keys not marked as important are considered to be verbose.

The UI is updated to reflect this change -- by splitting the data view tab into two separate tabs Data View (only displays important span annotations) and Verbose Data View (displays all span annotations).

Consider the Data View before:

before_dataview

It now renders as just:

after_data_view

And the new Verbose Data View:

after_verbose_dataview

Additionally the Traces page before:

before_traces

Has been updated to only display important annotations (which makes navigating lots of traces far easier):

after_traces

For a more extravagant example look at appdash demo which used to produce:

after_http_demo

And now produces just:

before_http_demo

slimsag commented 9 years ago

GitHub reports that the Travis build is still in progress -- yet Travis says it has completed one hour ago just fine. A little strange, no?