sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Prefix httptrace keys with Server/Client for clarity #52

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

This change prefixes the fields (using the trace struct tag) of httptrace.ServerEvent and httptrace.ClientEvent.

For details about why this change is important, please see the linked issue. But in short:

Before:


before


After:


after


Fixes issue #45.

Note: waiting on Travis build of #51 (hence included change).