Closed dmitshur closed 9 years ago
Ooh, just ran into this. It works on Firefox for me but not Chrome, probably because I disabled Flash in Chrome.
It'd be nice if it could just show you the JSON in a textarea (perhaps in a Bootstrap modal). Then you'd be able to copy it no matter what your plugin config was.
I think the best solution would be if Flash isn't available it should just open a popup with a textarea/JSON as @sqs said, it can be pre-selected for you so you can just hit "ctrl+c" (or cmd+c) etc.
I'm in full agreement with the above proposal.
I just noticed that this is still an issue, #68 fixed it for exporting single traces but not multiple on the /traces
page:
This is a possible enhancement, non-critical and low priority.
Right now it seems there's no handling of the case when Flash is not available in user's browser (either it's not installed, not available, or disabled).
Clicking "Copy as JSON" does nothing in such scenario.
If Flash is not available, perhaps something else should happen. Disable copying as json? Display a message saying "Sorry, Flash is needed for this functionality"? Display a text box popup that user can copy/paste? Do something else?
As an example of one way to handle such scenario, this is how GitHub looks like when you don't have Flash:
And this is how it appears when you do: