search

sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Fix LimitStore so multiple collections don't evict traces early. #76

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

This change adds a test (failing before and passing after this change) regarding a serious bug in LimitStore where it would treat each individual collection as the beginning of a new trace (i.e., evicting an "old" trace even though the "new" one is already inside the LimitStore!).

slimsag commented 9 years ago

I was waiting for the travis build but it's been ~1hr (and I've tried restarting it to no avail).

Tests pass on my local machine so I'm merging.