Closed evalphobia closed 8 years ago
This looks really great!
I left some comments inline, and let's change the wording slightly:
latency
to duration
(we use span duration
elsewhere in the code, so this is more accurate IMO).alphabet
to label
(because it's sorting by span label, this makes more sense / matches other UIs for sorting)Apologies for the delay on reviewing this!
@slimsag thank you for reviewing! I just fixed the code :baby_chick:
Thanks for the awesome contribution @evalphobia ! :sparkles:
This PR sort feature on trace view.
starting_time
ending_time
latency
(added new filed)label
(alphabetically)Each sort is worked as
ascending order
first click anddescending order
by clicking same button.