sourcegraph / appdash

Application tracing system for Go, based on Google's Dapper.
https://sourcegraph.com
Other
1.72k stars 137 forks source link

Added sort buttons on trace view #97

Closed evalphobia closed 8 years ago

evalphobia commented 8 years ago

This PR sort feature on trace view.

  1. sort order by starting_time
  2. sort order by ending_time
  3. sort order by latency (added new filed)
  4. sort order by label (alphabetically)

Each sort is worked as ascending order first click and descending order by clicking same button.

slimsag commented 8 years ago

This looks really great!

I left some comments inline, and let's change the wording slightly:

Apologies for the delay on reviewing this!

evalphobia commented 8 years ago

@slimsag thank you for reviewing! I just fixed the code :baby_chick:

slimsag commented 8 years ago

Thanks for the awesome contribution @evalphobia ! :sparkles: