search

sourcegraph / checkup

Distributed, lock-free, self-hosted health checks and status pages
https://sourcegraph.github.io/checkup
MIT License
3.42k stars 248 forks source link

Support for exporters #131

Closed mcdafydd closed 4 years ago

mcdafydd commented 4 years ago

Adds support for exporting test result data to external services. Allows external services to perform additional decision making or correlate with other data sources. Initial PR integrates with Azure Application Insights.

titpetric commented 4 years ago

Let’s start with the obvious question: why not just write a storage plugin for azure app insights?

mcdafydd commented 4 years ago

Now that I'm writing about it, that would be fine. I initially landed here because:

  1. I'm working on an azure blob storage plugin, which would be very similar to s3, and Application Insights feels like a fundamentally different use case than just storage
  2. I wanted this to run with or without the --store flag so I could choose to capture the stdout results as well. But, I suppose a serialized stdout storage plugin would be more useful in that regard than human-readable output,

If you're willing to consider merging, I'll rewrite this as a storage plugin. Also, I pulled in the stats because the API call just needs one value, but I can remove those changes and instead calculate an average in the plugin and include the raw times separately.

Thanks!

titpetric commented 4 years ago

If you’re willing, both the azure app insights and the stdout plugins seem very cool additions! I’m pretty sure I need to clean up the rest of checkup in regards to logging, so it doesn’t interfere with the stdout store.

Please be sure to rebase, and give a little footnote for changes outside of the storage plugins in the comments. I’ve seen a few line change regarding certstores in tcp/tls but haven’t tracked the godoc to verify if they make sense in that context. A tweet sized explanation why it’s needed and if it closes any issues is appreciated.

Thank you :)

On Mon, 6 Jul 2020 at 05:17, mcdafydd notifications@github.com wrote:

Now that I'm writing about it, that would be fine. I initially landed here because:

  1. I'm working on an azure blob storage plugin, which would be very similar to s3, and Application Insights feels like a fundamentally different use case than just storage
  2. I wanted this to run with or without the --store flag so I could choose to capture the stdout results as well. But, I suppose a serialized stdout storage plugin would be more useful in that regard than human-readable output,

If you're willing to consider merging, I'll rewrite this as a storage plugin.

Thanks!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/sourcegraph/checkup/pull/131#issuecomment-653993481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABY7EHUALVU62EVQOHA7J3R2E66JANCNFSM4OQUFEGA .

mcdafydd commented 4 years ago

Replacing with #132