Chat: fix abort message loading state - Githubissues

sourcegraph / cody

Type less, code more: Cody is an AI code assistant that uses advanced search and codebase context to help you write and fix code.

https://cody.dev

Apache License 2.0

2.27k stars 214 forks source link

Chat: fix abort message loading state #4601

Closed abeatrix closed 2 weeks ago

abeatrix commented 2 weeks ago

Part of https://linear.app/sourcegraph/issue/CODY-2149/feedback-bring-the-stop-button-back-again#comment-4c363fea

Notify the webview when aborting a message submission operation to indicate there is no message in progress
Update the priorAssistantMessageIsLoading prop to check if there is a message in progress, not just if the previous message was loading

Test plan

Ask Cody a question
Hit ESC to abort the request during the context fetching step
Verify the loading state disappeared on abort:

https://github.com/sourcegraph/cody/assets/68532117/a553602a-3772-484d-b1ea-3c559eef430a

Before

You will be stuck in this loading state even after you hit ESC to abort the request:

keegancsmith commented 2 weeks ago

This looks related to https://github.com/sourcegraph/cody/pull/4580?

abeatrix commented 2 weeks ago

This looks related to #4580?

@keegancsmith Yup! Tim asked me to fix it in a separate PR: https://linear.app/sourcegraph/issue/CODY-2149/feedback-bring-the-stop-button-back-again#comment-4c363fea