search

sourcegraph / cody

AI that knows your entire codebase
https://cody.dev
Apache License 2.0
2.24k stars 213 forks source link

remove /post-sign-up needless redirect #4664

Closed sqs closed 2 hours ago

sqs commented 1 week ago

After https://github.com/sourcegraph/sourcegraph/pull/63373, the /post-sign-up indirection/redirection is no longer necessary.

Test plan

Manually test in debug ext host sign out then sign in

chenkc805 commented 1 week ago

Let's wait to push this tomorrow, I know when @vdavid was working on this back in December we intentionally shipped it this way because this was a complicated flow. Here's some additional context:

sqs commented 4 days ago

@chenkc805 good to merge now? can you approve pls?

chenkc805 commented 4 days ago

I don't know this code well enough. @vdavid knows this code but he's on pat leave.

Let me look at the git blame to see who's a good person to review

chenkc805 commented 4 days ago

Looking at the git blame - both @philipp-spiess and @vdavid are unavailable to review this code. @dominiccooney - since you worked on the app-less signup flow last fall can I get your help reviewing this?