sourcegraph / cody

AI that knows your entire codebase
https://cody.dev
Apache License 2.0
2.22k stars 213 forks source link

Edit: Allow editing the inline diff #4684

Closed umpox closed 3 days ago

umpox commented 4 days ago

Description

closes https://github.com/sourcegraph/cody/issues/4671

https://github.com/sourcegraph/cody/assets/9516420/7d468713-c928-461b-b0f0-192a91560d44

Problem:

Solution:

Test plan

  1. Make Edits (Generate, Edit, Test, Fix, Document)
  2. Make changes to the diff
  3. Check everything looks ok
  4. Try to undo some of the changes you made
  5. Check the entire edit is not removed, as we're only undoing additional changes
  6. Undo all the changes made after the edit
  7. Check the entire edit is removed (e.g. codelens, injected whitespace, etc)
abeatrix commented 4 days ago

unrelated to this PR but we should also update the ghost text not to show up in diff lines?

image
umpox commented 3 days ago

Thanks @abeatrix I'll look into Gemini, maybe we should disable that for edit